Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error flag manually set to a gRPC server span gets overwritten #8042

Closed
sdwa0 opened this issue Dec 2, 2024 · 2 comments
Closed

Error flag manually set to a gRPC server span gets overwritten #8042

sdwa0 opened this issue Dec 2, 2024 · 2 comments
Assignees
Labels
inst: grpc gRPC instrumentation type: bug
Milestone

Comments

@sdwa0
Copy link

sdwa0 commented Dec 2, 2024

GrpcServerDecorator overwrites an error flag manually set to a gRPC server span, based on the status code returned by the gRPC server. That shouldn't be overwritten.

The behavior was slightly different before #7505, which was released in v1.39.0. Before the change, the gRPC server instrumentation code overwrote the error flag only when the gRPC server returned an error. Now, it overwrites the error flag regardless of the server response status.

Similar to what HttpServerDecorator does (introduced in #5359), GrpcServerDecorator can set the error flag with a lower priority.

@amarziali amarziali self-assigned this Dec 2, 2024
@amarziali amarziali added type: bug inst: grpc gRPC instrumentation labels Dec 2, 2024
@amarziali
Copy link
Collaborator

That's for having opened that issue and well detailed it. I think it makes sense. I opened a PR for it.

@amarziali amarziali added this to the 1.44.0 milestone Dec 2, 2024
Copy link
Contributor

🤖 This issue has been addressed in the latest release. Check full details in the Release Notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inst: grpc gRPC instrumentation type: bug
Projects
None yet
Development

No branches or pull requests

2 participants