contrib/internal/httptrace: proposal: Add option to ignore setting errors for 5xx HTTP status codes #2390
Labels
apm:ecosystem
contrib/* related feature requests or bugs
enhancement
quick change/addition that does not need full team approval
proposal/accepted
Accepted proposals
proposal
more in depth change that requires full team approval
Only errors located in the uppermost service span are processed by ErrorTracking.
We use
tracer.SetTag(ext.Error, err)
to record error in the uppermost service span.However, the gorilla/mux tracer we use which internally uses http tracer, also overrides the error with
tracer.SetTag()
when the HTTP Errors (5xx) occur.dd-trace-go/contrib/internal/httptrace/httptrace.go
Lines 74 to 76 in 6becedc
As a result, ErrorTracking groups all errors into a generic 5xx error issue, displays examples like
500: Internel Server Error
in its web UI.We'd like discuss about adding an option to ignore setting the error. this could be implemented as follows:
The text was updated successfully, but these errors were encountered: