Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/gomodule/redigo: Add support for WithSkipRawCommand #1707

Open
zball opened this issue Jan 31, 2023 · 0 comments
Open

contrib/gomodule/redigo: Add support for WithSkipRawCommand #1707

zball opened this issue Jan 31, 2023 · 0 comments
Labels
apm:ecosystem contrib/* related feature requests or bugs enhancement quick change/addition that does not need full team approval

Comments

@zball
Copy link

zball commented Jan 31, 2023

We use gomodule/redigo for our Redis implementation. For security reasons we'd like to add a config option to omit/obfuscate the redis.raw_command value when instrumenting with the contrib/gomodule/redigo package.

I'd like to propose adding a WithSkipRawComand option similar to the contrib/go-redis/redis.v8 package.
Here is the PR for that change. #1091 This request is just to bring parity between the two packages in this regard.

I'm happy to contribute a PR for this feature, I'm looking for some confirmation if it would be a welcome addition.
@zball zball added the enhancement quick change/addition that does not need full team approval label Jan 31, 2023
@katiehockman katiehockman added the apm:ecosystem contrib/* related feature requests or bugs label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
apm:ecosystem contrib/* related feature requests or bugs enhancement quick change/addition that does not need full team approval
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zball @katiehockman