Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datadog-Container-ID header is not sent #194

Open
ddyurchenko opened this issue Aug 24, 2021 · 3 comments
Open

Datadog-Container-ID header is not sent #194

ddyurchenko opened this issue Aug 24, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@ddyurchenko
Copy link

Hi guys,

I hope everything is going great for you! :)

I want to report a minor issue that I caught. I was testing nginx + cpp application inside Docker and found that Datadog-Container-Id header is never sent to /traces for opentracing-cpp instrumentation. According to Containers Tagging RFC https://github.com/DataDog/architecture/blob/master/rfcs/apm/agent/containers-tagging/rfc.md, it should be sent every time traces are sent.

Please feel free to contact me if you need any additional details.

@ddyurchenko ddyurchenko added the bug Something isn't working label Aug 24, 2021
@dgoffredo
Copy link
Contributor

This doesn't look too difficult.

It might be covered by telemetry work that we've discussed doing (but haven't scheduled) to collect information like this, kubernetes service, executable name, etc.

I'll mention it at the next standup meeting.

@paddycarey
Copy link

Curious if there's been any progress on this one? We're in the middle of an EC2->ECS migration for our NGINX instances and the lack of infrastructure-related tags on our NGINX traces is a problem.

I'm not an experienced C++ dev but happy to take a stab at this if it's desirable.

@dgoffredo
Copy link
Contributor

We haven't looked at this, sorry. The telemetry work that I mentioned has stalled, too.

It probably won't be a while until I or @cgilmour have the bandwidth to look into container ID detection in the tracer. Instead, is there a feature of the Datadog Agent that can discover the nginx container's ID instead? I looked over the RFC linked above, and it doesn't look like it.

Also, what's the plan for dealing with cgroup v2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants