Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writes debug files by default to a hard-coded location and doesn't remove them #184

Open
deadok22 opened this issue Jun 21, 2021 · 3 comments
Milestone

Comments

@deadok22
Copy link

Since #147, the library writes some debug information to a /var/tmp/dd-opentracing-cpp/startup_options-*.json file on startup. This is problematic:

  • The users risk running out of disk in environments where the processes consuming the library are started frequently (this did actually happen in my setup with NGINX Ingress Controller)
  • The hard-coded location is bad for portability

I believe this output should be turned off by default and its destination should be made configurable.

@deadok22
Copy link
Author

Just noticed the code in question was commented out in #150, so this report may be obsolete.

@cgilmour cgilmour added this to the 1.3.1 milestone Jun 21, 2021
@cgilmour
Copy link
Contributor

Thanks for reporting this @deadok22, and although this had good intentions (it's very useful information for support teams), I agree it's problematic and it did later get removed. As other projects update, it'll stop being a problem.

The code should have been removed instead of commented out - an oversight on my part. Let's leave this issue open until that has been cleaned up.

@dgoffredo
Copy link
Contributor

The most recent release of the ingress controller includes this version of the datadog tracer, which includes Caleb's fix.

I don't know how to upgrade an ingress controller, but doing so will likely resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants