[dogshell] add hostname by default to event/metric posts #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, `dogshell` event posts (`dog event post` command) are now automatically associated with the local host. The `--host` and `--no-host` (new) options allow to override this value with a given host, or no host. ```python # Event is associated with the local host dog event post "title" "content" # Event is associated with `foo.bar` host dog event post --host "foo.bar" "title" "content" # Event is not associated with any host dog event post --no-host "title" "content" ```
By default, `dogshell` event posts (`dog metric post` command) are now automatically associated with the local host. The `--host` and `--no-host` (new) options allow to override this value with a given host, or no host. The `--localhostname` option is deprecated, as made default when no `--host` is set. ```python # Metric is associated with the local host dog metric post "metric.example" 1 # Metric is associated with `foo.bar` host dog metric post --host "foo.bar" "metric.example" 1 # Metric is not associated with any host dog metric post --no-host "metric.example" 1 ```
|
@JohnLZeller can you take a pass at it please ? |
|
Looks good! 👍 |
yannmh
added a commit
that referenced
this pull request
Mar 10, 2016
[dogshell] add hostname by default to event/metric posts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[dogshell] add hostname by default to event posts
By default,
dogshellevent posts (dog event postcommand) are nowautomatically associated with the local host.
The
--hostand--no-host(new) options allow to override this valuewith a given host, or no host.
[dogshell] add hostname by default to metric posts
By default,
dogshellevent posts (dog metric postcommand) are nowautomatically associated with the local host.
The
--hostand--no-host(new) options allow to override this valuewith a given host, or no host.
The
--localhostnameoption is deprecated, as made default when no--hostis set.Fix #115