Document parameter alert_type in Event.create #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're right About testing, this could be the subject of a small addition in our integration test suite ✅. I'll make the according changes in a separate pull request. |
yannmh
added a commit
that referenced
this pull request
Jan 5, 2016
Document parameter alert_type in Event.create
|
@yannmh Thanks. Yeah, I was going to add it to the integration test suite but I could not see how to run it :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, you've forgot to document the parameter
alert_typeinEvent.create. I guess there should also be a test for this, but I wasn't sure how to go about this.