-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BETA] Full client-side aggregate with histogram, distribution and timing #176
Conversation
f2abf81
to
cae8d57
Compare
cae8d57
to
ea6839b
Compare
ea6839b
to
4b7823d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick review and it looks good to me 👍
WithAgentMinVersion
IMO, the typical usage of datadog-go is to create once statsd
with statsd.New
+ some options and never update it. If some users really care about using the latest features, REAME.md file and/or the release note can contain the recommended settings with their requirements.
IMO, using WithAgentMinVersion
does not bring much compared to an up to date documentation (updating the version in the application using datadog-go or checking the documentation is the same amount of work).
If we really want to handle the Agent version, the Agent can expose the version as an endpoint. As there is a single feature using the Agent version, I think it does not worth adding this kind of endpoint at the moment.
4b7823d
to
0369bd6
Compare
0369bd6
to
b2531ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We now buffer values for those types and pack them in one dogstatsd message. This is based on the new dogstatsd 1.1 protocol.
b2531ec
to
224e72f
Compare
full client side aggregation for histogram and distribution. This feature use the new beta protocol 1.1 for dogstatsd allowing sending multiple values per message.
This also add the
WithAgentMinVersion
setting to trigger feature link to the agent version. For now only client side aggregation for histograms, distribution and timing which requires agent>=7.25
or>=6.25&&<7.0.0
.