Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce permissions for milestone github actions #58

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

anmarchenko
Copy link
Member

Closes #50

What does this PR do?
This PR reduces the permission of the add-milestone-to-pull-requests and create-next-milestone GitHub Actions to the minimum possible.

Motivation
See pull requests for dd-trace-rb repository explaining the motivation:

DataDog/dd-trace-rb#3193
DataDog/dd-trace-rb#3194

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

One of the things that... worries me about the multiple repos solution is us not having a great solution to maintain these things in sync, other than "someone noticed, and opened a PR on the other side".

@anmarchenko
Copy link
Member Author

@ivoanjo yes, this is a tradeoff that we make currently and I don't like it too

let's try to run it like this for enough time and then we can find enough similarities to start extracting them

@ivoanjo
Copy link
Member

ivoanjo commented Oct 24, 2023

Yeap, sounds reasonable!

@anmarchenko anmarchenko merged commit 9f6d671 into main Oct 25, 2023
11 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/reduce_github_actions_permissions branch October 25, 2023 11:47
@github-actions github-actions bot added this to the 0.4.0 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce permissions for GitHub Actions
2 participants