[SDTEST-1229] Skip before(:all) context hooks when all examples are skipped #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l tests are skipped by test impact analysis
anmarchenko
force-pushed
the
anmarchenko/rspec_skip_example_group
branch
from
a5a8d1c to
6df2a5a
Compare
…ed in ExampleGroup
…e the logic to check if a test should be skipped in the current test run
…Example is skippable by test impact analysis
y9v
approved these changes
Dec 4, 2024
romainkomorndatadog
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #256
Improves handling of RSpec context hooks when tests are skipped by test impact analysis: now we will skip context hooks if we know that all examples in the context are going to be skipped by Datadog.
Motivation
See #256
Additional Notes
This PR doesn't address another limitation of context hooks with test impact analysis: when we collect impacted files for test (aka per test code coverage), we don't cover context hooks (because they cannot be attributed to any single test). This can lead to skipping tests that should not be skipped. I reprioritised the issue with context hooks coverage higher because there is new evidence that context hooks are being used by our customers.
How to test the change?
Unit tests are provided