introduce chef_handler_enable to control the chef reporting #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about something like include_recipe 'datadog::dd-handler' if node['datadog']['chef_handler_enable']in datadog::dd-agent? |
|
because I'd like to have the installation of the gem already done , just enable/disable the handler reporting |
|
@jedi4ever I don't know if I like wrapping the entire resource in an |
miketheman
added a commit
that referenced
this pull request
Mar 20, 2014
rather follow it, for readability. Refs #95
|
Thanks @jedi4ever ! I added a commit to style the resource here: 3e23489 - better view: 3e23489?w=1 |
miketheman
added a commit
that referenced
this pull request
Mar 20, 2014
n1koo
pushed a commit
to Shopify/chef-datadog
that referenced
this pull request
Oct 20, 2014
rather follow it, for readability. Refs DataDog#95
n1koo
pushed a commit
to Shopify/chef-datadog
that referenced
this pull request
Oct 20, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Controlling the agent stop and start is not enough to prevent data to be send from a host to datadog.
The chef handler reports directly via the gem, so we need another flag :
node[:datadog][:chef_handler_enable]