-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new APT and RPM signing keys #890
Conversation
d907526
to
ffff3b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just leave a small question, otherwise looks good to me!
@@ -42,13 +44,55 @@ | |||
|
|||
expect(chef_run.remote_file('remote_file_DATADOG_APT_KEY_CURRENT.public')).to notify( | |||
'execute[import apt datadog key DATADOG_APT_KEY_CURRENT.public]').to(:run).immediately | |||
expect(chef_run.remote_file('remote_file_5F1E256061D813B125E156E8E6266D4AC0962C7D')).to notify( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity, shouldn't the new key become the current key ? Or we must wait before switching ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will become the current key when we actually start using it (we're not using it yet).
a7a12be
to
2086953
Compare
What does this PR do?
Addition of the new key for signing rotation process
Motivation
Regular signing key rotation process
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Install the agent packages pushed on trial repository
Reviewer's Checklist