Added the option to enable USM #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cswatt
approved these changes
Jan 9, 2023
bkabrda
approved these changes
Jan 18, 2023
@bkabrda did the kitchen test fail due to my changes? |
|
@guyarb no, they're broken because of unrelated dependency upgrade. We'll fix the tests and if it's ok with you, then we'll rebase your branch to get the tests run and merge it if everything succeeds. |
|
Oh wait, this is a PR from a fork... So we'll notify you when we fix main and ask you to rebase yourself, because we can't rebase branch in your fork. |
|
@amenasria can you merge the PR? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added the option to enable USM
Motivation
enabling USM
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist