Don't use epoch/release for yum package version on Chef < 14 #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffbyrnes
pushed a commit
to jeffbyrnes/chef-datadog
that referenced
this pull request
Aug 25, 2022
) In DataDog#856, we reverted the logic introduced in DataDog#839 when Chef < 14 is used, as the yum logic in Chef < 14 doesn't support the use of epochs. However, before DataDog#839, the release was added in all cases to the package version. In DataDog#856 we forgot to restore that, which this PR does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The yum logic has been rewritten in Chef 14 and using epoch/release is correct (and necessary), however on Chef < 14 not using epoch/release is correct (and necessary).