Enable yum repository repo_gpgcheck option for Red Hat platforms by default #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvaka
reviewed
Apr 26, 2021
attributes/default.rb
Outdated
| @@ -160,6 +160,13 @@ | |||
| default['datadog']['aptrepo_use_backup_keyserver'] = false | |||
| default['datadog']['aptrepo_keyserver'] = 'hkp://keyserver.ubuntu.com:80' | |||
| default['datadog']['aptrepo_backup_keyserver'] = 'hkp://pool.sks-keyservers.net:80' | |||
| # repo_gpgcheck on RHEL 5 requires additional packages (e.g. pygpgme) that might not | |||
| # always be installed/available in enabled repositories | |||
| default['datadog']['yumrepo_repo_gpgcheck'] = if platform_family?('rhel') && node['platform_version'].to_i < 6 | |||
There was a problem hiding this comment.
If a user has defined their own yumrepo URL pointing to a custom repo which isn't signed, this would be a breaking change for them. We can check that and default to false in that case. For example, we could make yumrepo_repo_gpgcheck default to nil, and then at runtime calculate the actual default (true or false) based on:
- the existing logic for rhel5.
- whether
yumrepoisnil(default repo) or not (custom repo).
Wdyt?
There was a problem hiding this comment.
Good point. I'll fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm wondering whether we should document this - there doesn't seem to be any section in README.md that explicitly deals with gpg keys, repository URLs etc - I'm assuming because the users never really hit issues with these and so they didn't need documenting?