Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install dd agent with yum on Amazon Linux 1 #731

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Install dd agent with yum on Amazon Linux 1 #731

merged 1 commit into from
Aug 4, 2020

Conversation

tymartin-novu
Copy link
Contributor

It turns out that Amazon Linux 1 identifies with the following node platform attributes, which cause the linux dd agent install recipe to treat it like RHEL >=8:

platform: amazon
platform_version: 2018.03
platform_family: rhel

I believe we would rather have the dd agent package get installed with the yum_package resource on Amazon Linux 1 instead of the dnf_package resource.

Relates to #641

@tymartin-novu tymartin-novu requested a review from a team as a code owner August 3, 2020 19:10
julien-lebot
julien-lebot approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@julien-lebot julien-lebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, that change looks good to me, merging !

@julien-lebot julien-lebot merged commit e1aeef7 into DataDog:master Aug 4, 2020
@julien-lebot julien-lebot added this to the 4.5.0 milestone Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-lebot julien-lebot julien-lebot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tymartin-novu @julien-lebot