-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds generated recipes for missing checks #730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
fc132a7
to
f9e3c61
Compare
Adds recipes created with `bundle exec rake create_integration_monitor` introduced in #720 I didn't include checks that already have recipes since in some cases it causes behavior changes or renames, so we might want to wait for a major release bump to do that.
And by not ignoring the init_config
f9e3c61
to
2f2e004
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic change looks good to me. I only have one question:
I didn't include checks that already have recipes since in some cases it
causes behavior changes or renames, so we might want to wait for a major
release bump to do that. Except for riak, since it looked safe to replace.
For riak, this PR adds:
init_config node['datadog']['riak']['init_config']
...
use_integration_template true
Is this change safe because it doesn't actually change the behavior of the integration?
Yes, the previous recipe used the riak template [1] which essentially results in the same as the default template [2] except that the riak template only took into account the [1] https://github.com/DataDog/chef-datadog/blob/master/templates/default/riak.yaml.erb |
Fixes
bundle exec rake create_integration_monitor
introduced in #720and adds 54 recipes created with it.
I didn't include checks that already have recipes since in some cases it
causes behavior changes or renames, so we might want to wait for a major
release bump to do that. Except for riak, since it looked safe to replace.
Left out
zk
,elastic
andcouch
even though they are "new" recipesbecause they aren't actually new: the current ones are named
zookeeper
,elasticsearch
andcouchdb
, which don't match the generated filenames.