Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds generated recipes for missing checks #730

Merged
merged 6 commits into from
Sep 16, 2020

Conversation

albertvaka
Copy link
Contributor

@albertvaka albertvaka commented Jul 13, 2020

Fixes bundle exec rake create_integration_monitor introduced in #720
and adds 54 recipes created with it.

I didn't include checks that already have recipes since in some cases it
causes behavior changes or renames, so we might want to wait for a major
release bump to do that. Except for riak, since it looked safe to replace.

Left out zk, elastic and couch even though they are "new" recipes
because they aren't actually new: the current ones are named zookeeper,
elasticsearch and couchdb, which don't match the generated filenames.

@albertvaka albertvaka requested a review from a team as a code owner July 13, 2020 15:44
Copy link
Contributor

@julien-lebot julien-lebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@albertvaka albertvaka force-pushed the albertvaka/new-generated-checks branch from fc132a7 to f9e3c61 Compare September 15, 2020 14:45
Adds recipes created with `bundle exec rake create_integration_monitor`
introduced in #720

I didn't include checks that already have recipes since in some cases it
causes behavior changes or renames, so we might want to wait for a major
release bump to do that.
@albertvaka albertvaka force-pushed the albertvaka/new-generated-checks branch from f9e3c61 to 2f2e004 Compare September 15, 2020 15:24
Copy link
Contributor

@KSerrania KSerrania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic change looks good to me. I only have one question:

I didn't include checks that already have recipes since in some cases it
causes behavior changes or renames, so we might want to wait for a major
release bump to do that. Except for riak, since it looked safe to replace.

For riak, this PR adds:

  init_config node['datadog']['riak']['init_config']
...
  use_integration_template true

Is this change safe because it doesn't actually change the behavior of the integration?

@albertvaka
Copy link
Contributor Author

albertvaka commented Sep 16, 2020

Yes, the previous recipe used the riak template [1] which essentially results in the same as the default template [2] except that the riak template only took into account the url field within the instances array. Now it will still support the url field, plus any other field you add.

[1] https://github.com/DataDog/chef-datadog/blob/master/templates/default/riak.yaml.erb
[2] https://github.com/DataDog/chef-datadog/blob/master/templates/default/integration.yaml.erb

@albertvaka albertvaka merged commit 1ff61fb into master Sep 16, 2020
@albertvaka albertvaka deleted the albertvaka/new-generated-checks branch September 16, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants