-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of IOT agent flavor #717
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (but I don't know Chef so maybe someone else should look at it too). Left a small nit.
attributes/default.rb
Outdated
@@ -40,6 +40,8 @@ | |||
# Example: | |||
# default['datadog']['agent_version'] = '7.16.0' | |||
default['datadog']['agent_version'] = nil # nil to install latest | |||
# Agent flavor, acceptable values are "agent", iot-agent" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: on the Agent we use agent
and iot_agent
for the flavors, maybe we could use those values here too for consistency? I am not sure if the other ones are user-facing though, but just in case they ever are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like iot-agent
better because it matches the name of the package (datadog-iot-agent
). The flavor
names in the Agent code are to identify them on our side, but shouldn't be user-facing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks Albert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to document the new field in the README.
Would it be easier to set |
+1 to Kylian, it will also ease adding support for flavors that don't start with "datadog-" like dogstatsd. |
Co-authored-by: Albert Vaca <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
It adds the base logic to support agent flavors. And it adds the support of the IOT agent.
Motivation
Allowing users to install specific flavors of the agent.