Revert windows login leaks #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvaka
approved these changes
Mar 3, 2020
CHANGELOG.md
Outdated
| @@ -1,10 +1,10 @@ | |||
| Changes | |||
| ======= | |||
|
|
|||
| # 4.2.0 / 2020-02-27 | |||
| # 4.2.0 / 2020-02-27 - BROKEN | |||
There was a problem hiding this comment.
Suggested change
| # 4.2.0 / 2020-02-27 - BROKEN | |
| # 4.2.0 / 2020-02-27 - KNOWN BUG |
CHANGELOG.md
Outdated
|
|
||
| * [FEATURE] Automatically uninstall and then install the Agent only when trying to downgrade agent version on Windows. See [#690][] [@kbogtob][] | ||
| * [BUGFIX] Set Windows installer as sensitive resource and use env var to specify Windows user credentials to avoid leaks of credentials in logs. See [#691][] and [#694][] [@julien-lebot][] | ||
| * [BUGFIX] Set Windows installer as sensitive resource and use env var to specify Windows user credentials to avoid leaks of credentials in logs. See [#691][] and [#694][] [@julien-lebot][] - Broken: This bugfix introduces a new bug blocking users not using credentials to install on Windows |
There was a problem hiding this comment.
Suggested change
| * [BUGFIX] Set Windows installer as sensitive resource and use env var to specify Windows user credentials to avoid leaks of credentials in logs. See [#691][] and [#694][] [@julien-lebot][] - Broken: This bugfix introduces a new bug blocking users not using credentials to install on Windows | |
| * [BUGFIX] Set Windows installer as sensitive resource and use env var to specify Windows user credentials to avoid leaks of credentials in logs. See [#691][] and [#694][] [@julien-lebot][] - Known bug: This bugfix introduces a new bug blocking users not using credentials to install on Windows |
kbogtob
force-pushed
the
kbogtob/revert-windows-login-leaks
branch
from
1587d41
to
33204a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reverting #694 and #691
Motivation
Users could not use the cookbook to install the agent on Windows without credentials
Fixes: #698