[monitor] fix issues with directory creation on windows #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSerrania
reviewed
Dec 30, 2019
resources/monitor.rb
Outdated
| group 'dd-agent' | ||
| mode '755' | ||
| if node['platform_family'] == 'windows' | ||
| if Chef::Datadog.agent_major_version(node) > 5 |
There was a problem hiding this comment.
I think this check is not needed, we're already in the Chef::Datadog.agent_major_version(node) != 5 branch
There was a problem hiding this comment.
Yes, this is exactly what I was talking about, I hadn't even bother checking the logic, thanks.
truthbk
commented
Dec 31, 2019
kbogtob
reviewed
Dec 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bit of copy/paste going on here, so I'm sure this can be fixed in a cleaner way. I'll let you guys take the PR over, but it should be fixed as this is currently broken on windows.