Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] download fix powershell script with chef, then execute. #657

Merged
merged 4 commits into from
Nov 15, 2019

Conversation

truthbk
Copy link
Member

@truthbk truthbk commented Nov 15, 2019

Let's allow chef take care of the fix script downloading duties for better TLS behavior with cloudfront.

Copy link
Contributor

@julien-lebot julien-lebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, if you've tested this works well :)

@truthbk truthbk merged commit ccb5c22 into master Nov 15, 2019
@truthbk truthbk deleted the jaime/dl_fix branch November 15, 2019 20:17
truthbk added a commit that referenced this pull request Nov 15, 2019
* [windows] download the fix with chef, not powershell

* [windows] ensure we get the script AND run the validation when we're about to uninstall

* [windows] fix bad source for remote PS script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants