default: remove deprecated options. #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
approved these changes
May 20, 2019
There was a problem hiding this comment.
LGTM overall!
I think you missed that one:
chef-datadog/attributes/default.rb
Line 265 in 71dde6c
Support for create_dd_check_tags has also been removed in v6.0.
It might make sense to group all of the agent v5-only attributes at the end of the file (for readability), in the same way the v6-only ones are grouped, but up to you 👍
In any case, feel free to merge whenever
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a comment for Agent v5 only options to easily remove them the day we'll drop the support of Agent v5.