Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datadog_integration resource to install integrations. #600

Merged
merged 5 commits into from
Mar 29, 2019

Conversation

remeh
Copy link
Contributor

@remeh remeh commented Mar 26, 2019

This PR adds the datadog_integration resource to be able to setup Agent integrations directly from a Chef recipe.

@remeh remeh added the feature label Mar 26, 2019
@remeh remeh added this to the 3.0 milestone Mar 26, 2019
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty great, this'll be awesome for our users 👍

just a couple of questions.

level :debug
end

execute 'integration install' do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might require running with elevated: true on windows? right? I'm not sure but be sure to test out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. We can't really use elevated: true because it would mean to ask for user credentials to execute this. I've added a note for Chef Windows users that the running chef-client must have read access to the datadog.yamlfile.

resources/integration.rb Show resolved Hide resolved
@@ -11,7 +11,7 @@ platforms:
# - name: ubuntu-12.04
- name: centos-6.6
- name: centos-7.7
- name: debian-7.7
- name: debian-8.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why kill debian-7.7? Incompatibility?

Copy link
Contributor Author

@remeh remeh Mar 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just for now, CircleCI uses the regular wheezy docker images which are not working anymore since Debian has put wheezy in archive. I'll restore wheezy tests when debian/eol images of wheezy will be available.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@truthbk truthbk Mar 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jessie was also removed from the mirror network, and moved into the archive. I think that's why the tests are failing, I suppose we'll need to wait for the updated builders and perhaps bump all the way to stretch to test this out.

@remeh remeh added the ready label Mar 27, 2019
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@remeh remeh merged commit 835471a into master Mar 29, 2019
@remeh remeh deleted the remeh/integration-command branch March 29, 2019 09:07
@olivielpeau
Copy link
Member

A bit late to the party, but this looks great! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants