Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent v6 by default #594

Merged
merged 18 commits into from
Mar 27, 2019
Merged

Agent v6 by default #594

merged 18 commits into from
Mar 27, 2019

Conversation

remeh
Copy link
Contributor

@remeh remeh commented Mar 18, 2019

Agent v6 will now be installed by default.

  • README updated (for example a complete section on how to v5 -> v6 or v6 -> v5 has been added)
  • Some things moved/changed in default/attributes.rb to reflect this changes.
  • Update the tests:
    • CircleCI will still run for Agent v5
    • Spec tests have been partially updated: some were testing Agent v5 only, an extra effort could be done to add some for Agent v6, some were already added for Agent v6 directly.

@remeh remeh added this to the 3.0 milestone Mar 18, 2019
@remeh remeh changed the title Default on installing Agent v6 Agent v6 by default Mar 20, 2019
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

Left a few comments, but feel free to merge once addressed!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@remeh remeh added the ready label Mar 22, 2019
@remeh remeh merged commit a71c0a1 into master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants