-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename package[apt-transport-https] resource for Chef 13 compatibility #388
Conversation
Hello @bai, thank you for your contribution and explanation ! We try to avoid as much as possible setting requirements for our dependencies if there is another way around (even if the requirement is loose), and I think there is be in this case: renaming the resource. If I'm right, this would allow us to maintain our current level of compatibility with the On a side note, do you know when Chef 13 will be released ? I couldn't find an official release date. In the long term, we will definitely use your solution, but we know that for now some of our customers are still using an older Let me know what you think or our proposed solution, or if you have any question! |
This will happen April 2017 per this accepted RFC for release cadence |
Apologies with getting this one forgotten, I've pushed the fix. 👀 EDIT: Updated title/description. |
Friendly bump 💯 cc: @olivielpeau |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed your push & previous comment. 😞
Thank you for making this change!
It means we'll have to release a new cookbook version for Chef 13 @olivielpeau (hopefully this is the only needed change) - thank you for linking this RFC @martinisoft, I didn't know about it.
@degemer I noticed that there are also Chef13 deprecation warnings/errors related to https://github.com/DataDog/chef-datadog/blob/master/recipes/dd-handler.rb#L90 See https://github.com/chef-cookbooks/chef_handler/issues/45 for more details |
Thanks for reporting this @andrewjamesbrown ! Do you have the same issue with chef_handler 2.x ? We haven't had a chance to test it yet, but if it fixes this issue and the behaviour stays the same, we could relax this requirement: https://github.com/DataDog/chef-datadog/blob/master/metadata.rb#L25 |
This PR renames
package[apt-transport-https]
to avoid resource cloning.Currently, when DataDog cookbook used with
apt
cookbook 2.9.1 or later (released October 24, 2015), Chef throws a deprecation warning:Originally this PR suggested to just remove the resource and bump
apt
cookbook dependency but it's been decided to rename the resource instead — for those who depend on an olderapt
cookbook elsewhere.