Add support for any config options #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
degemer
force-pushed
the
quentin/support-any-config-key
branch
2 times, most recently
from
ed56583
to
cec18ac
Compare
olivielpeau
suggested changes
Oct 21, 2016
| @@ -221,6 +221,11 @@ | |||
| # extra_packages to install | |||
| default['datadog']['extra_packages'] = {} | |||
|
|
|||
| # extra config options | |||
| # If an agent is released with a new config option which is not yet supported by this cookbook | |||
| # you can use this attribute to set it. Will be ignored if falsy. | |||
There was a problem hiding this comment.
I think we should ignore the value only if it's nil. We have agent configuration options that are true by default so setting them to false is meaningful. Thoughts?
There was a problem hiding this comment.
(also, if you agree, a test on that would be perfect :) )
There was a problem hiding this comment.
Makes sense. I didn't think of false, only of '', which is useless since ini requires key: value.
| @@ -221,6 +221,11 @@ | |||
| # extra_packages to install | |||
| default['datadog']['extra_packages'] = {} | |||
|
|
|||
| # extra config options | |||
There was a problem hiding this comment.
nit: could you put this right under default['datadog']['histogram_percentiles'] in this file, so that it's visually regrouped with the other agent config attribute defaults?
degemer
force-pushed
the
quentin/support-any-config-key
branch
from
cec18ac
to
42c058f
Compare
It is annoying to have to wait for a new cookbook release when an agent is released with a new config option. This commit aims to fix it by allowing any config options to be added.
degemer
force-pushed
the
quentin/support-any-config-key
branch
from
42c058f
to
f712ee6
Compare
|
Updated @olivielpeau, ready for round 2! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is annoying to have to wait for a new cookbook release when an agent
is released with a new config option.
This commit aims to fix it by allowing any config options to be added.
Fix #336