Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moar chefspec testing #35

Merged
merged 3 commits into from
Dec 26, 2012
Merged

Moar chefspec testing #35

merged 3 commits into from
Dec 26, 2012

Conversation

miketheman
Copy link
Contributor

Attempts to start to cover all the "promises" we make in a recipe, which may diverge per platform, and verify that if the code changes, the promised behavior will not.

@clofresh
Copy link

I get an error when I run rake spectest:

$ rake spectest
(in /Users/carlo/Projects/datadog/chef-datadog)
rake aborted!
/Users/carlo/Projects/datadog/chef-datadog/Rakefile:12: syntax error, unexpected ':', expecting kEND
    style.max_line_length 160, level: :warn
                                     ^
/Users/carlo/Projects/datadog/chef-datadog/Rakefile:19: syntax error, unexpected ':', expecting kEND
    style.max_line_length 160, level: :warn
                                     ^
/Users/carlo/Projects/datadog/chef-datadog/Rakefile:23: syntax error, unexpected ':', expecting kEND
    style.max_line_length 160, level: :warn
                                     ^

(See full trace by running task with --trace)

@miketheman
Copy link
Contributor Author

@clofresh I suspect this might be a Ruby version problem. What version are you using?
Also, the command is rake chefspec vs rake spectest.

@clofresh
Copy link

Ruby 1.8.7. Yeah it's erroring on any rake commands, even rake -T

@miketheman
Copy link
Contributor Author

@clofresh Ought to work now, I added Ruby 1.8.7-style for the Rakefile syntax.
Note: Tests like foodcritic require Ruby 1.9.3.

Ruby 1.8.7 is scheduled for End Of Life as of June 2013 and is already in Maintenance-only mode.

@miketheman
Copy link
Contributor Author

Any objections to merging this?

miketheman added a commit that referenced this pull request Dec 26, 2012
@miketheman miketheman merged commit 9e1a1eb into master Dec 26, 2012
iancward added a commit to iancward/chef-datadog that referenced this pull request Oct 15, 2017
olivielpeau pushed a commit that referenced this pull request Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants