Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Agent v6 on yum-based platforms #90

Merged
merged 1 commit into from
Jan 8, 2018
Merged

Support Agent v6 on yum-based platforms #90

merged 1 commit into from
Jan 8, 2018

Conversation

brendanlong
Copy link
Contributor

  • Add the DataDog yum beta repo
  • Use yum_repository instead of manual files
  • Fix some places where we don't update or restart the agent
  • Create /etc/datadog

@hush-hush
Copy link
Member

Hi @brendanlong,

Thanks for the PR ! I'll take a look at it as soon as possible (most likely next week). Thanks for your patience.

hush-hush
hush-hush requested changes Jan 5, 2018
View reviewed changes
Copy link
Member

@hush-hush hush-hush left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brendanlong,

Thanks a lot for this PR !
You need to add ANSIBLE0006 to the list of excluded rules here for the travis test to succeed.

Also, could you update the CHANGELOG by adding your change to a new 1.5.0 section ?

defaults/main.yml
datadog_agent6_apt_repo: "deb http://apt.datadoghq.com beta main"
datadog_agent6_yum_repo: "https://yum.datadoghq.com/beta/{{ ansible_userspace_architecture }}/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't plan on shipping 32 bits packages for the agent6. I think we could still keep the ansible_userspace_architecture, it will result in an error when ansible is run on unsupported architecture.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to add a check for that or something?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good with having an error at install time. I just wanted to leave a comment here for future reference.

@brendanlong
Support Agent v6 on yum-based platforms
713f217 
 - Add the DataDog yum beta repo
 - Fix some places where we don't update or restart the agent
 - Create /etc/datadog
@brendanlong
Copy link
Contributor Author

@hush-hush I updated the changelog and added that new exclude rule.

@hush-hush hush-hush merged commit 380b44c into DataDog:master Jan 8, 2018
@hush-hush
Copy link
Member

Thanks a lot @brendanlong for the PR !

@brendanlong brendanlong deleted the yum-agent6 branch January 8, 2018 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hush-hush hush-hush hush-hush requested changes

Assignees

@hush-hush hush-hush

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brendanlong @hush-hush