Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing for custom yum repo #80

Merged
merged 3 commits into from
Oct 24, 2017
Merged

Conversation

ncracker
Copy link
Contributor

@ncracker ncracker commented Oct 4, 2017

/etc/yum.repos.d/datadog.repo is still being created, but its URL content is customizable
Repo name and filename remain

/etc/yum.repos.d/datadog.repo is still being created, but its content is customizable
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment, other than that LGTM 👍

# default yum repo and keys
datadog_yum_repo: "https://yum.datadoghq.com/rpm/{{ ansible_userspace_architecture }}/"
datadog_yum_gpgkey: "https://yum.datadoghq.com/DATADOG_RPM_KEY.public"
datadog_rpm_gpgkey: "http://yum.datadoghq.com/DATADOG_RPM_KEY_E09422B3.public"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rename this one datadog_yum_gpgkey_new?

@olivielpeau olivielpeau added this to the 1.4.0 milestone Oct 24, 2017
@olivielpeau olivielpeau merged commit 6b7583d into DataDog:yum-custom-repo Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants