Allow pinning the version of the Agent #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And encourage users to pin the version.
hush-hush
approved these changes
Apr 4, 2017
README.md
Outdated
| @@ -17,14 +17,16 @@ Role Variables | |||
| -------------- | |||
|
|
|||
| - `datadog_api_key` - Your Datadog API key. | |||
| - `datadog_checks` - YAML configuration for agent checks to drop into `/etc/dd-agent/conf.d`. | |||
| - `datadog_agent_version` - The pinned version of the Agent to install (optional, but highly recommended) | |||
| Examples: `1:5.12.3-1` on apt-based platforms, `5.12.3-1` on yum-based platforms- `datadog_checks` - YAML configuration for agent checks to drop into `/etc/dd-agent/conf.d`. | |||
There was a problem hiding this comment.
I guess we're missing a line break after "platforms" ?
Addresses review comment [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And encourage users to pin the version. Addresses #57
By default we still auto-upgrade the agent, let's change this default behavior in the next major release of this role