Add macOS support #437
Merged
Add macOS support #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added another commit to fix ansible-lint issues. For some reason, ansible-lint started complaining on files that weren't touched by this PR. Technically it would've been better if I did another PR to fix the issues, but I figured that this would be easier and avoid rebasing. |
albertvaka
approved these changes
May 4, 2022
Co-authored-by: Albert Vaca Cintora <[email protected]>
Co-authored-by: Albert Vaca Cintora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds macOS support to our ansible role. Some notes:
dmgpackage work, the package will install a login item and start a user-specific LaunchAgent if (and only if)ansible_useris also currently logged in via GUI. There are tasks that handle this by deactivating the LaunchAgent and login item when this happens.datadog_macos_userand defaults toansible_user.dmgdownload URL by specifyingdatadog_macos_download_url.Huge thanks go to @lc-applause for sending the basis of this functionality!