Add datadog_manage_config to disable changing the Agent config files #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSerrania
reviewed
Jan 20, 2022
|
We don't have any unit tests on this repo 😅 😅 😅 Only kitchen tests and a setup for manual tests (I used the later). Should I maybe add a kitchen test? |
albertvaka
force-pushed
the
albertvaka/add-datadog-manage-config
branch
3 times, most recently
from
b2a73ea
to
4a1d4cc
Compare
albertvaka
force-pushed
the
albertvaka/add-datadog-manage-config
branch
from
4a1d4cc
to
5a1d7ac
Compare
KSerrania
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new variable
datadog_manage_configthat defaults totruebut can be set tofalse. Doing so will make our role not change any of the Agent config files when it runs. This allows using the role to update the Agent if manual modifications have been made to the config files without overwriting them.