Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid usage of ansible_lsb to not depend on lsb-release package on Debian #377

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Avoid usage of ansible_lsb to not depend on lsb-release package on Debian #377

merged 1 commit into from
Jul 19, 2021

Conversation

bkabrda
Copy link
Contributor

@bkabrda bkabrda commented Jul 19, 2021

Using ansible_lsb actually requires lsb-release package on Debian/Ubuntu, otherwise it won't contain some values. This PR makes the task use ansible_distribution_major_version which is a fact gathered regardless of lsb-release presence.

Fixes #376.

@bkabrda bkabrda requested a review from a team as a code owner July 19, 2021 08:24
@bkabrda bkabrda merged commit b481e3d into master Jul 19, 2021
@bkabrda bkabrda deleted the slavek.kabrda/dont-use-ansible_lsb branch July 19, 2021 08:55
@bkabrda bkabrda mentioned this pull request Jul 19, 2021
Closed
@blackandred blackandred mentioned this pull request Apr 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KSerrania KSerrania KSerrania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

debian:buster-slim is missing lsb-release package
2 participants
@bkabrda @KSerrania