Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Cloud Workfload Security agent configuration #375

Merged

Conversation

alsmola
Copy link
Contributor

@alsmola alsmola commented Jul 6, 2021

This change adds the Cloud Workload Security agent configuration described here: https://docs.datadoghq.com/security_platform/cloud_workload_security/getting_started/

I haven't tested this, but I'm hoping it's a good start for the DataDog devs to get into master so we can use this new feature.

@alsmola alsmola requested review from a team as code owners July 6, 2021 17:01
@alsmola alsmola force-pushed the add-support-for-runtime-security-config branch 4 times, most recently from 0ea3819 to 73a4766 Compare July 6, 2021 17:20
README.md Show resolved Hide resolved
@alsmola alsmola requested review from jtappa and removed request for a team July 8, 2021 16:07
Copy link
Contributor

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋 thanks a lot for sending this PR! It looks really good and works fine according to my testing. I just left one minor note inline about updating README. Once that's addressed, I can merge.

README.md Outdated
@@ -173,6 +173,8 @@ The system probe is configured under the `system_probe_config` variable. Any var

[Network Performance Monitoring][7] (NPM) is configured under the `network_config` variable. Any variables nested underneath are written to the `system-probe.yaml`, in the `network_config` section.

[Cloud Workload Security][8] is configured under the `runtime_security_config` variable. Any variables nested underneath are written to the `system-probe.yaml` and `security-agent.yaml`, in the `runtime_security_config` section.

**Note**: The system probe works on Linux with Agent v6+. NPM is supported on Windows with Agent v6.27+ and v7.27+.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add a note here about the Cloud Workload Security being only supported on Linux and requiring Agent 6.27+/7.27+?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks!

@alsmola alsmola force-pushed the add-support-for-runtime-security-config branch from 69508c4 to 699346b Compare July 14, 2021 16:46
@bkabrda
Copy link
Contributor

bkabrda commented Jul 15, 2021

Looks perfect now, I'm merging. Thanks again for your contribution!

@bkabrda bkabrda merged commit a4e125a into DataDog:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants