Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set repo_gpgcheck=1 by default on RHEL/CentOS 8.1 and on custom repos #352

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

bkabrda
Copy link
Contributor

@bkabrda bkabrda commented Apr 28, 2021

Due to a bug in dnf, repo_gpgcheck doesn't work in non-interactive shells in RHEL/CentOS 8.1. This PR implements logic that disables repo_gpgcheck on these platforms. It also disables repo_gpgcheck on custom repos.

@bkabrda bkabrda requested review from a team as code owners April 28, 2021 13:22
@bkabrda
Copy link
Contributor Author

bkabrda commented Apr 28, 2021

Hmm, I'll also need to not set repo_gpgcheck=true for zypper custom repos. Please hold review until I finish that.

Copy link

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs 👍

@bkabrda
Copy link
Contributor Author

bkabrda commented Apr 29, 2021

Done, ready for review from my side.

@bkabrda bkabrda merged commit 6d30fa1 into master Apr 29, 2021
@bkabrda bkabrda deleted the slavek.kabrda/repo-gpgcheck-rhel-81 branch April 29, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants