Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for overriding the debian package name- to allow picking up the iot release! #309

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

NickJLange
Copy link
Contributor

Add support for the playbook installing the iot agent. There is no functionality change outside of this bit of surgery.

@NickJLange NickJLange requested review from a team as code owners October 30, 2020 02:53
@albertvaka
Copy link
Contributor

Could you name this something like datadog_agent_flavor and make it work for both apt and rpm? There's no need for this to be only available for apt.

Copy link
Contributor

@sarina-dd sarina-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small period addition, 👍 lgtm for docs

README.md Outdated Show resolved Hide resolved
Add support for Raspberry Pi/IOT with by making the package name a variable.
@NickJLange
Copy link
Contributor Author

Change makes sense. I don't have a rhel box at home to test but the debian changes went through just fine.

Copy link
Contributor

@albertvaka albertvaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks a lot for making the change for RHEL 🙇 🙇 🙇

@albertvaka albertvaka merged commit d4eaeb8 into DataDog:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants