-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CentOS] Use dnf instead of yum with Python 3 #301
Conversation
ce61d13
to
5ab9828
Compare
5ab9828
to
128cf71
Compare
Co-authored-by: Pablo Baeyens <[email protected]>
I'm not 100% sure that we should fail hard when we detect Python 3 + CentOS < 8. On one side, it quickly gives a helpful message and avoids going through half of the role tasks only to find out that it doesn't work, but on the other side, there could be a case where someone backports |
We could add a flag to ignore the hard fail to deal with that edge case. I don't think it's a likely situation but it doesn't harm to have that flag I suppose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 docs look good
What does this PR do?
Use the
dnf
task instead ofyum
when we detect that a Python 3 interpreter is used on a target host.Add CentOS 8 tests to the CI.
Add Python 2 / Python 3 tests to the CI.
Motivation
The
yum
Python module is not compatible with Python 3.Should fix #298.
Additional Notes
CentOS / RHEL < 8 + Python 3 interpreter is an invalid setup (you can't use the
dnf
module either because thepython3-dnf
package doesn't exist on these versions of CentOS), so we fail early in that case, with a helpful error message.