Fix error when facts value don't exist #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested, can confirm fix |
mx-psi
approved these changes
Jun 23, 2020
|
Hi @kanga333, thanks for your contribution! LGTM, so I am going to merge it 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix #282
Resolves installation errors that occur in the Redhat OS family of the arm architecture.
Additional information
ansible_userspace_architectureis undefined in arm because it is a variable that is only set on Intel family CPUs.https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/facts/system/platform.py#L61-L72
I used
varsand changed it to useansible_architectureifansible_userspace_architectureis undefined.https://docs.ansible.com/ansible/latest/plugins/lookup/vars.html
Describe your test plan
Install this version of the role using
Running on an arm architecture machine, such as an AWS m6g instance.
I have run the test plan and have confirmed that it ran successfully.