Only try stop sysprobe if it is installed #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kevinconaway
suggested changes
Jan 30, 2020
tasks/agent-linux.yml
Outdated
| @@ -94,7 +94,7 @@ | |||
| name: datadog-agent-sysprobe | |||
| state: stopped | |||
| enabled: no | |||
| when: not datadog_skip_running_check and (not datadog_enabled or not datadog_sysprobe_enabled) | |||
| when: not datadog_skip_running_check and (not datadog_enabled or not datadog_sysprobe_enabled) and ansible_facts.services['datadog-agent-sysprobe'] is defined | |||
There was a problem hiding this comment.
We'll want to check both type of services as done here:
ansible-datadog/tasks/agent-linux.yml
Line 83 in 8db7a6a
Perhaps we can create a fact about whether the service is installed or not (datadog_sysprobe_installed?) and use that here and in the datadog_sysprobe_enabled fact check.
There was a problem hiding this comment.
Yeah good shout, I'll sort that
kevinconaway
approved these changes
Jan 31, 2020
|
Hi guys, would we be able to release this on Galaxy? Our provisioning is still failing because of this 👍 |
|
Hi @dv9io0o, I'll do a bugfix release today to include this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #249 where if sysprobe wasn't installed, the provision would still try and stop the service and fail as it doesn't exist