Allow apt repo settings to be user defined #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,7 +2,11 @@ | |||
| - apt: name=apt-transport-https state=latest | |||
|
|
|||
| - apt_key: id=C7A7DA52 keyserver=hkp://keyserver.ubuntu.com:80 state=present | |||
| when: apt_key_url is not defined | |||
There was a problem hiding this comment.
This should be datadog_apt_key_url
|
Hi @geoffwright, thanks for your contribution! I've added a few comments on your PR, let me know what you think. Also, can you remove your last commit from your PR (9a2a29a)? The change it provides has already been merged through a separate PR. Thanks! |
To enable deploys using a local apt mirror. New variables: * datadog_apt_repo * datadog_apt_key_url
|
Merging, thanks @geoffwright! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow the use of local apt mirrors