Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FTP support to AbstractJobStore._get_size #5134

Closed
stxue1 opened this issue Oct 24, 2024 · 1 comment · Fixed by #5142
Closed

Add FTP support to AbstractJobStore._get_size #5134

stxue1 opened this issue Oct 24, 2024 · 1 comment · Fixed by #5142

Comments

@stxue1
Copy link
Contributor

stxue1 commented Oct 24, 2024

_get_size currently doesn't support FTP as it requires special commands and wizardry.

This will also need to support extracting username/password from the URL and/or supporting environmental variables to override the username/password

This will allow FTP files to work with #5133

┆Issue is synchronized with this Jira Story
┆Issue Number: TOIL-1660

@mr-c
Copy link
Contributor

mr-c commented Oct 25, 2024

I implemented the equivalent of this in https://github.com/ohsu-comp-bio/cwl-tes/blob/03f0096f9fae8acd527687d3460a726e09190c3a/cwl_tes/ftp.py#L231
Feel free to steal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants