Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar is cool but... #3069

Closed
glennhickey opened this issue May 22, 2020 · 3 comments
Closed

Progress bar is cool but... #3069

glennhickey opened this issue May 22, 2020 · 3 comments

Comments

@glennhickey
Copy link
Contributor

glennhickey commented May 22, 2020

It requires the terminal to be reset when run in a screen session. Also, for cactus anyway, it spends the vast majority of the runtime at 99%/100%.

┆Issue is synchronized with this Jira Task
┆Issue Number: TOIL-558

@adamnovak
Copy link
Member

adamnovak commented May 22, 2020

The reset issue might be the same as Rockhopper-Technologies/enlighten#16 which was closed for insufficient information. Maybe we can pick that back up.

The bar is going to spend most of its time almost done because it can only see the issued jobs. If we want it to use not-yet-ready-to-run jobs in the denominator we need an efficient way to get those from the job store, without walking the whole stored tree and with some notion of completed, deleted jobs, which I think we don't have.

@avylove
Copy link

avylove commented May 23, 2020

@glennhickey, do you still see the issue with enlighten 1.5.2?

@glennhickey
Copy link
Contributor Author

Upgrading to 1.5.2 does seem to fix it. Thanks @avylove -- this seems like a simple patch for toil then..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants