Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Unable to add app handler? #13

Closed
JR-Mitchell opened this issue Jun 25, 2024 · 0 comments
Closed

Bug: Unable to add app handler? #13

JR-Mitchell opened this issue Jun 25, 2024 · 0 comments

Comments

@JR-Mitchell
Copy link

It is possible to call KCEF.init with a builder that has an app handler supplied, like:

KCEF.init(
    builder = {
        addAppHandler(myAppHandler)
    }
)

However, none of the overridden methods of myAppHandler appear to be called.

This appears to be because of the line at line 93 of KCEF.kt:

currentBuilder.addAppHandler(AppHandler)

While the name of addAppHandler seems to suggest that multiple app handlers can be added, by looking at its implementation in CefAppHandler.java it seems that this is not true, and any subsequent call to it will remove any previously set app handler.
So it looks like the issue may be that this call in KCEF.kt removes any app handler that is added in the builder.

zaroxh added a commit to zaroxh/KCEF that referenced this issue Jul 11, 2024
@zaroxh zaroxh mentioned this issue Jul 11, 2024
DatL4g pushed a commit that referenced this issue Jul 11, 2024
@DatL4g DatL4g closed this as completed Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants