Bare Imports

[mattpilott]

I have run into an issue when importing dashjs, using it as a regular script tag works but as an npm module it does not. I have made a repro linked below which exhibits the issue.

Steps to reproduce

https://github.com/matt3224/sapper-dash

Observed behaviour

When importing dash like import dashjs from "dashjs" i get the following issue:

Module specifier, 'stream' does not start with "/", "./", or "../". 

Console output

'stream' is imported by node_modules/sax/lib/sax.js, but could not be resolved – treating it as an external dependency
'string_decoder' is imported by node_modules/sax/lib/sax.js, but could not be resolved – treating it as an external dependency
'stream' is imported by stream?commonjs-external, but could not be resolved – treating it as an external dependency
'string_decoder' is imported by string_decoder?commonjs-external, but could not be resolved – treating it as an external dependency

Thanks!!

[mattpilott]

Related article http://dplatz.de/blog/2019/es6-bare-imports.html

[bbert]

Have you tried this?:

import * as dashjs from 'dashjs'

[mattpilott]

@bbert this yields the same result unfortunately

[heff]

Same issue here while trying to use Rollup to compile my app with dashjs. Found the related sax.js issue.

I tried some of the suggestions of requiring stream manually with no luck. I think they may need to happen at the dashjs level before packaging.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed because no further activity occurred. If you think this issue is still relevant please reopen it. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. However, it might still be relevant so please leave a short comment if it should remain open. Otherwise the issue will be closed automatically after two weeks. Thank you for your contributions.

[dsilhavy]

unstale

[stale]

This issue has been automatically marked as stale because it has not had recent activity. However, it might still be relevant so please leave a short comment if it should remain open. Otherwise the issue will be closed automatically after two weeks. Thank you for your contributions.

[dsilhavy]

unstale

[FossPrime]

Having a similar issue in Vite, you'd ostensibly have the same issue in Deno and php-js.

The main culprit seems to be the sax package... which expects tons of global pollution.

My cringe workaround is to do the following, afterwards bruteforce the global into your code with const dashjs = globalThis.dashjs.MediaPlayer as unknown as any

export default defineConfig({
  resolve: {
    alias: {
      dashjs: path.resolve(
        __dirname,
        './node_modules/dashjs/dist/dash.all.min.js'
      )
    }
  }

[TravisC1]

I too was having issues with dashjs and vite, thanks rayfoss for the workaround. Would love a proper solution, though 👀

[stale]

This issue has been automatically marked as stale because it has not had recent activity. However, it might still be relevant so please leave a short comment if it should remain open. Otherwise the issue will be closed automatically after two weeks. Thank you for your contributions.

[stale]

This issue has been automatically closed because no further activity occurred. If you think this issue is still relevant please reopen it or contact @dsilhavy. Thank you for your contributions.