Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to PhotoSwipe 5+ #11

Open
raoulbhatia opened this issue Jul 30, 2023 · 2 comments
Open

Upgrade to PhotoSwipe 5+ #11

raoulbhatia opened this issue Jul 30, 2023 · 2 comments

Comments

@raoulbhatia
Copy link

PhotoSwipe 5 was released as a major upgrade on 2022-03-28 [1]

Features include

  • Code quality and rewrite in ES6
  • Simpler initialization and dynamic import support
  • Animation and gesture engine update
  • Single CSS file and no external assets
  • Built-in responsive images support
  • Open images in zoomed state

There were several features removed. It seems there is support for a plugin-architecture.

Please consider an upgrade.

Thanks,
Raoul

[1] https://github.com/dimsemenov/PhotoSwipe/releases?q=v5&expanded=true

@Darthagnon
Copy link
Owner

This is desirable, but only e.g. as an alternate branch alongside PhotoSwipe 4, as v5 deprecated support for older browsers. As v4 still works perfectly well with modern browsers, this is a long-term goal. I remember disliking the new animations, vs v4, too, and care more about long-term stability, wide usability, rather than new features.

Perhaps the non-ESM version of PSWP v5 will help with compatibility ("If you are unable to use ES modules...")?

@Darthagnon
Copy link
Owner

Darthagnon commented Jul 30, 2023

it might not work in IE11, Opera Mini, UC browser, and old versions of Chrome, Safari, and Firefox. Check your website/region statistics before deciding whether you should use PhotoSwipe or not.

- PSWP v5 docs

That said, having tested the current v4 implementation (e.g. https://casaldecultura.com/posts/galeria/) and the PhotoSwipe v5 demo, they seem to behave the same in IE11 (see also #3). Needs testing in some other legacy browsers; if behaviour is consistent, then no reason not to update other than "time" lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants