Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added demands support at build definition level #92

Merged
merged 1 commit into from
Sep 15, 2018
Merged

Added demands support at build definition level #92

merged 1 commit into from
Sep 15, 2018

Conversation

hangar18rip
Copy link
Contributor

@hangar18rip hangar18rip commented Sep 13, 2018

PR Summary

Added the Demands property to the VSTeamBuildDefinition type
Added a sample demands array in the VSTS build definition sample file to validate the change during the unit tests

PR Checklist

@hangar18rip
Copy link
Contributor Author

hi @DarqueWarrior
Do you plan to make the pipeline public so we can check the CI issue during the pull requests ?
regards,
Olivier

@DarqueWarrior
Copy link
Collaborator

I do plan to make the build public. I just have to secure a few more keys in the build def.

@DarqueWarrior
Copy link
Collaborator

Your build only failed because PRs don't have permissions to change the build number which the build currently does now. I am working to change that.

@DarqueWarrior DarqueWarrior merged commit 59083be into MethodsAndPractices:master Sep 15, 2018
@DarqueWarrior
Copy link
Collaborator

Thanks for the support your changes are live now in version 4.0.6. I really appreciate it.

@hangar18rip
Copy link
Contributor Author

Glad to contribute. Thanks for deploying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants