Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converted VSTeamQueue from format/type to class #84

Merged
merged 46 commits into from
Sep 8, 2018
Merged

converted VSTeamQueue from format/type to class #84

merged 46 commits into from
Sep 8, 2018

Conversation

KaiWalter
Copy link
Contributor

PR Summary

converted VSTeamQueue to class and added it

  • to the project root in the provider
  • to Build Definition

PR Checklist

  • [Write Unit Test]

Tests executed successfully

.\unit\test\buildDefinitions.Tests.ps1;
.\unit\test\queues.Tests.ps1;
.\unit\test\pools.Tests.ps1;

Tests executed

.\integration\test\010_projects.Tests.ps1;

I encountered a problem with my VSTS test account - but that should have no impact

  Context Feed exercise
    [-] Add-VSTeamFeed should add a feed 2.95s
      WebException: The remote server returned an error: (402) Payment Required.
...

KaiWalter and others added 30 commits July 26, 2018 22:14
Can navigate build defs for TFS and VSTS
@DarqueWarrior
Copy link
Collaborator

Man, you are getting work done! Thank you so much for the support. While I was reviewing this pr I found that one of the unit tests is failing.

Describing TeamsPSDrive

    Context VSTeamAccount & Projects
      [+] Should create VSTeamAccount 99ms
      [+] Should return projects 72ms
      [-] Should return builds, releases, repositories and teams

Looks like you added queues to the projects Get-ChildItems but did not update the test.

@KaiWalter
Copy link
Contributor Author

fixed TeamPSDrive unit test and ran all units tests sucessfully

$files = @(); gci -Path .\unit\test\ -Filter *tests*.ps1 | %{$files+=$_.FullName}; invoke-pester -Script $files

@KaiWalter
Copy link
Contributor Author

@DarqueWarrior is it possible that you grant me at least R/O rights to the CI - so I can check errors

@DarqueWarrior
Copy link
Collaborator

I want to! I can't!. We are working through public projects and permissions. But now you can't change the build number which the build does. Sorry for the issue. I hope we get this fixed.

@DarqueWarrior DarqueWarrior merged commit df2acba into MethodsAndPractices:master Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants