Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Remove Agent" function #70

Merged
merged 10 commits into from
Aug 1, 2018

Conversation

Geertvdc
Copy link
Contributor

PR Summary

Added a function to remove vsts agents from a pool. by calling Remove-Agent or Remove-VSTeamAgent

PR Checklist

i didn't update the readme. thought it was something to be added when you do a new release right?

@DarqueWarrior
Copy link
Collaborator

Please add

[CmdletBinding(SupportsShouldProcess = $true, ConfirmImpact = "Medium")]

And add a force switch parameter.

if ($force -or $pscmdlet.ShouldProcess($item, "Remove Agent")) {

You can look at Set-VSTeamApproval for an example. Otherwise looks great. Thanks for the support.

@Geertvdc
Copy link
Contributor Author

I've updated these two things

@DarqueWarrior DarqueWarrior merged commit eb9f93c into MethodsAndPractices:master Aug 1, 2018
@Geertvdc Geertvdc deleted the remove-agent branch August 2, 2018 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants