Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to pass parameters when queueing builds #45

Merged
merged 8 commits into from
Mar 27, 2018
Merged

Added ability to pass parameters when queueing builds #45

merged 8 commits into from
Mar 27, 2018

Conversation

karpis
Copy link

@karpis karpis commented Mar 18, 2018

Also fixed some failing tests that were using removed parameters and obsolete Pester functions

@karpis
Copy link
Author

karpis commented Mar 21, 2018

Found an issue. Will fix and create a new PR

@karpis karpis closed this Mar 21, 2018
@karpis
Copy link
Author

karpis commented Mar 25, 2018

Found the problem. The parameters section of the request body is a string and must be serialized as such.

@karpis karpis reopened this Mar 25, 2018
@DarqueWarrior
Copy link
Collaborator

Can you resolve the conflicts caused by the merge of your other PR?

@karpis
Copy link
Author

karpis commented Mar 26, 2018

Done :)

@DarqueWarrior DarqueWarrior merged commit 8e42211 into MethodsAndPractices:master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants