Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GET Approval filter by release ids #39

Merged
merged 3 commits into from
Feb 27, 2018
Merged

Fix GET Approval filter by release ids #39

merged 3 commits into from
Feb 27, 2018

Conversation

franciscocabral
Copy link
Contributor

@franciscocabral franciscocabral commented Feb 20, 2018 •
edited
Loading

API documentation says that to filter by release id is needed the query param releaseIdsFilter not releaseIdFilter

@franciscocabral
Fix filter by release ids
9e9fd9f 
API [documentation](https://www.visualstudio.com/en-us/docs/integrate/api/rm/approvals) says that to filter by release id, is needed the query param `releaseIdsFilter` not `releaseIdFilter`
@DarqueWarrior
Copy link
Collaborator

Thanks for spotting this. I will update the help to match. I will also add an alias for the parameter so we don't break any scripts that might already be setting that value. Finally I will bump the version.

@DarqueWarrior
Merge PR #39
1676688 
Updated Help
Updated Readme
Updated Version
@DarqueWarrior
Merge from darquewarrior master
05c9ca4
@DarqueWarrior DarqueWarrior merged commit cae351e into MethodsAndPractices:master Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franciscocabral @DarqueWarrior